Sherlock-72 (continuation - move quote token): Lenders pay deposit fees due to no slippage control #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es due to no slippage control
grandizzy
requested review from
dmitriia,
prateek105,
MikeHathaway,
ith-harvey,
mattcushman and
EdNoepel
EdNoepel
reviewed
Jun 30, 2023
There was a problem hiding this comment.
This is consistent with the proposed approach.
Assume the lender is already below the LUP, but is trying to move above the LUP. Even if they pass true, seems they will not get a revert. So the slippage protection is really only for those lenders currently above the LUP?
|
that's correct. lenders moving from below LUP won't pay deposit fee so slippage control to protect against is not needed |
dmitriia
reviewed
Jun 30, 2023
| @@ -290,7 +290,8 @@ contract PositionManager is PermitERC721, IPositionManager, Multicall, Reentranc | |||
| uint256 tokenId_, | |||
There was a problem hiding this comment.
Shouldn't revert list be expanded with revertIfBelowLup_ case:
/**
* @inheritdoc IPositionManagerOwnerActions
* @dev External calls to `Pool` contract:
* @dev `bucketInfo()`: get from bucket info
* @dev `moveQuoteToken()`: move liquidity between buckets
* @dev === Write state ===
* @dev `TokenInfo.positionIndexes`: remove from bucket index
* @dev `TokenInfo.positionIndexes`: add to bucket index
* @dev `TokenInfo.positions`: update from bucket position
* @dev `TokenInfo.positions`: update to bucket position
* @dev === Revert on ===
* @dev - `mayInteract`:
* @dev token id is not a valid / minted id
* @dev sender is not owner `NoAuth()`
* @dev token id not minted for given pool `WrongPool()`
* @dev - positions token to burn has liquidity `RemovePositionFailed()`
* @dev - tried to move from bankrupt bucket `BucketBankrupt()`
* @dev === Emit events ===
* @dev - `MoveQuoteToken`
* @dev - `MoveLiquidity`
*/There was a problem hiding this comment.
the possible underlying reverts are not listed here but only the reverts from function logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
High level
revertIfBelowLupparam added toPool.moveQuoteTokenandPositionManager.moveLiquidityfunctiontruethen the tx will revert if move happens belowLUPprice (hence avoid paying fee).falsemove belowLUPwill go through and deposit fee paidMoveQuoteParamsstruct moved from inline in order to avoid stack too deep errorPoolcontract size by reading structs in view functions only onceContract size
Pre Change
Post Change
Gas usage
Pre Change
Post Change